Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel_embeddings.py and feasibility.py minor corrections #259

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jackraymond
Copy link
Contributor

Minor improvements to new parallel_embeddings.py and feasibility.py modules:

  • max_num_emb should be optional, allowing a None value that indicates no bound on the number of embeddings. This has been implemented.
  • The lattice_size() function is merely a helper function for find_sublattice_embeddings() and doesn't have much generalization power beyond this. For this reason I have moved it into the parallel_embeddings.py module. Separately, a new non-trivial upper-bound function could be added to feasibility.py as a feature enhancement (noted in comments).

Andy Zhang and others added 3 commits December 23, 2024 11:05
jackraymond added a commit to AndyZzzZzzZzz/shimming-tutorial that referenced this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant