Zephyr layout #190
Merged
Zephyr layout #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boothby
force-pushed
the
zephyr_layout
branch
from
f2ad8d1 to
62ff706
Compare
randomir
reviewed
Nov 3, 2021
| @@ -172,7 +172,7 @@ def _parse_layout_parameter(S, T, layout, layout_kwargs): | |||
| T_layout = t_layout | |||
| else: | |||
| # Use the dnx_layout if possible | |||
| if T.graph.get("family") in ("chimera", "pegasus"): | |||
| if T.graph.get("family") in ("chimera", "pegasus", "zephyr"): | |||
There was a problem hiding this comment.
Perhaps create an Enum for known families? Should prevent typos.
There was a problem hiding this comment.
I don't disagree, but to do that properly, we'd probably want to define that enum in dwave_networkx. How important do you think this is?
There was a problem hiding this comment.
Makes sense. I don't think it's critical, as in a blocker of this PR. I'll open an issue.
There was a problem hiding this comment.
Slightly related; leaving this here so it doesn't get lost.
Chatting with Kelly we were considering the following unified scheme
topology = dnx.Topology("zephyr")
g = topology.generator(16)
topology.plotter(g)to avoid tedious if elif logic that tends to appear everywhere:
if topology == 'pegasus':
generator = pegasus_graph
plotter = draw_pegasus
elif topology == 'zephyr':
generator = zephyr_graph
plotter = draw_zephyr
g = generator(5)
plotter(g)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.