Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout p norm #121

Merged
merged 6 commits into from
Apr 1, 2020
Merged

Layout p norm #121

merged 6 commits into from
Apr 1, 2020

Conversation

stefanhannie
Copy link
Contributor

The p_norm layout algorithm is introduced.

  • It is a Kamada-Kawai inspired algorithm that drops some of the more graph drawing aspects of their algorithm and generalizes the distance function to the p-norm.

Stefan Hannie added 5 commits March 30, 2020 17:05
P_norm layout
3c0331f 
A Kamada-Kawai-like algorithm with a variable p-norm distance function.
Now also passing dim, center, scale as kwargs to layout callables.
Set p_norm as find_embedding default
b961531
p_norm unit test
f15467c 
test_dimension also changed as the behavior is slightly different now.
Minor changes
065e6c9 
Layout.d changed to Layout.dim, documentation changes, split a test.
Timeout changed to perf_counter
4577ea6
boothby
boothby reviewed Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@boothby boothby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, one lil typo

minorminer/layout/layout.py Outdated Show resolved Hide resolved
@boothby boothby merged commit d56ee52 into dwavesystems:master Apr 1, 2020
@stefanhannie stefanhannie deleted the layout-p_norm branch April 1, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boothby boothby boothby left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanhannie @boothby