Skip to content

Commit

Permalink
Skip keyboard interrupt tests on macOS + py39 (#176)
Browse files Browse the repository at this point in the history
Reason for failures is not clear, but it's probably related to signal
handling in lower-level libraries. Deeper investigation is required,
but left for #175.
  • Loading branch information
randomir authored Dec 9, 2020
1 parent 6338043 commit 6832264
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/test_lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -873,10 +873,10 @@ def run_interactive_interrupt(interactive):


@skip_if(
# there appears to be a bug in the osx, py3.8 version of multiprocessing.
# there appears to be a bug in the osx, py3.8+ version of multiprocessing.
# this has turned into a yak-shaving exercise and I'm not doing any more here
# for the time being -- #TODO if anybody has a mac and they wanna dig in, please do
(sys.version_info[:2] == (3, 8) and sys.platform == 'darwin') or
(sys.version_info[:2] >= (3, 8) and sys.platform == 'darwin') or
# TODO this test seems to actually work on windows but it's doing something funky
# to our appveyor framework. Giving up on yak-shaving 'cause we're going to retire
Expand All @@ -889,10 +889,10 @@ def test_interactive_interrupt():


@skip_if(
# there appears to be a bug in the osx, py3.8 version of multiprocessing.
# there appears to be a bug in the osx, py3.8+ version of multiprocessing.
# this has turned into a yak-shaving exercise and I'm not doing any more here
# for the time being -- #TODO if anybody has a mac and they wanna dig in, please do
(sys.version_info[:2] == (3, 8) and sys.platform == 'darwin') or
(sys.version_info[:2] >= (3, 8) and sys.platform == 'darwin') or
# TODO this test seems to actually work on windows but it's doing something funky
# to our appveyor framework. Giving up on yak-shaving 'cause we're going to retire
Expand Down

0 comments on commit 6832264

Please sign in to comment.