-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TilingComposite support for Advantage processor #431
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on the docstrings, I'll look at the code next
(Happy you're doing this; we'll finally be able to dump #294 :-))
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
- Coverage 90.85% 87.60% -3.26%
==========================================
Files 22 22
Lines 1455 1492 +37
==========================================
- Hits 1322 1307 -15
- Misses 133 185 +52
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for a pegasus processor with missing qubits?
…ra tile_around_hole test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not due to this PR but I think tiling.py is missing an import warnings
statement for
warnings.warn("Incomplete solver topology information." |
… Got rid of deprecation warning and made topology argument a requirement
…her PEP8 corrections and typos.
Testing both edge defects and node defects independently for the tiling composite (and other functions) is quite important so I added that functionality to MockDWaveSampler as well. |
@JoelPasvolsky, do you want to finish reviewing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, gives good results for all the tests I tried.
The TilingComposite has been modified to allow tiling of Chimera structured problems over Pegasus as well as Chimera solvers.
This is an important use case for certain users, who wish to compare Chimera-structured (or chimera embeddable) problems between the DW2000Q and Advantage generation processors, at high sample density.
Some minor fixes were also introduced for Chimera case, catching some pathological behaviours.
The DWaveMockSampler has been modified to support Pegasus as well as Chimera structured solver emulation.
These changes allow straightforward generalization for the case of Zephyr topologies.
These changes do not resolve all known outstanding issues with TilingComposite e.g. #295 . This supports tiling of Chimera problems over Advantage (Pegasus-structured) processors, further changes are required to support tiling of Pegasus problems over Advantage (or DW2000Q) processors.