Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C++ section of contributing guide and include .clang-format #90

Merged
merged 8 commits into from
Oct 26, 2020

Conversation

shpface
Copy link
Contributor

@shpface shpface commented Sep 9, 2020

No description provided.

Copy link
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to provide a short code snippet that demonstrates the flavour of our naming and formatting guidelines. Not sure we can capture the essence in ~15 lines, though.

CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
.clang-format Outdated Show resolved Hide resolved
.clang-format Outdated Show resolved Hide resolved
Added a couple more bullets to naming convention
Linked to Google's guide
Removed Additional Style subsection
Added 15 lines of example code. It obviously leaves much uncovered, but perhaps captures the essence of the style.
@arcondello arcondello mentioned this pull request Oct 26, 2020
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@arcondello arcondello self-assigned this Oct 26, 2020
@arcondello arcondello requested a review from randomir October 26, 2020 20:19
Copy link
Member

@randomir randomir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arcondello arcondello merged commit a270f7d into dwavesystems:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants