Feature/coloring: Four colorings for Zephyr and Pegasus, and a two coloring for Chimera #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arcondello I review this |
kevinchern
suggested changes
Oct 17, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
+ Coverage 75.81% 75.96% +0.14%
==========================================
Files 31 31
Lines 2171 2184 +13
==========================================
+ Hits 1646 1659 +13
Misses 525 525 ☔ View full report in Codecov by Sentry. |
kevinchern
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
can use set equality instead otherwise LGTM. passing the ball to poseidon/neptune (@arcondello / @randomir)
tests/test_regular_coloring.py
Outdated
| G = graph(*topology_shape, coordinates=True) | ||
| col_dict = {q: color(q) for q in G.nodes} | ||
| self.assertTrue(np.all(np.unique(list(col_dict.values())) == | ||
| np.arange(num_colors))) |
There was a problem hiding this comment.
Suggested change
| np.arange(num_colors))) |
randomir
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colorings of minimal chromatic number on Chimera, Pegasus and Zephyr graphs in the form of a map using the standard coordinate schemes.