-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for torus QPU graph variations #225
Conversation
…and resolve a type warning
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
==========================================
+ Coverage 75.18% 75.66% +0.47%
==========================================
Files 31 30 -1
Lines 2112 2174 +62
==========================================
+ Hits 1588 1645 +57
- Misses 524 529 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm making this PR review in slices to help you get it in quickly. This first one is mostly on the chimera.py
updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments for another slice: pegasus.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Third slice (for Zephyr). I think that should cover most of what I'll spend time looking at
Very nice addition, @jackraymond
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Joel Pasvolsky <[email protected]>
… into feature/torus
Implemented review comments in full. Some docstring issues remained in edge_list and node_list, these have been subsequently simplified. Some other minor formatting and compliance issues were addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests could use some PEP8 love, but otherwise LGTM!
The primary purpose of this pull request is to provide generators for the instances evaluated in https://arxiv.org/abs/2202.03044 [BBRR].
The pull request: