Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement partitioning and tests #216

Merged
merged 2 commits into from
Dec 18, 2021

Conversation

necaisej
Copy link

Starting over for this PR to get away from git history issues.

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #216 (9ee62ae) into main (4ade84b) will increase coverage by 0.41%.
The diff coverage is 97.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   74.42%   74.84%   +0.41%     
==========================================
  Files          29       30       +1     
  Lines        2045     2083      +38     
==========================================
+ Hits         1522     1559      +37     
- Misses        523      524       +1     
Impacted Files Coverage Δ
dwave_networkx/algorithms/partition.py 97.29% <97.29%> (ø)
dwave_networkx/algorithms/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ade84b...9ee62ae. Read the comment docs.

@necaisej
Copy link
Author

@arcondello Started this PR to deal with the history issues; comments from previous PR mostly addressed here

Copy link
Member

@arcondello arcondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The graph to partition.
num_partitions : int, optional (default 2)
The number of subsets in the desired partition.
sampler
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a :

equation or a Quadratic Model, with or without constraints. The sampler
is expected to have a 'sample_cqm' method. A sampler is expected to
return an iterable of samples, in order of increasing energy.
sampler_args
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a :

@arcondello arcondello merged commit bcd47b2 into dwavesystems:main Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants