Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access of cmap argument #207

Merged
merged 1 commit into from
Oct 22, 2021
Merged

Fix access of cmap argument #207

merged 1 commit into from
Oct 22, 2021

Conversation

mcfarljm
Copy link

Closes #173. cmap was not available in kwargs because it was explicitly declared as a keyword argument.

Also considered removing the explicit cmap keyword argument, in which cmap could be contained in the kwargs dict that gets propagated to networkx.draw, but I don't think that is the intent.

cmap was not available in kwargs because it was explicitly declared as a kwarg.
Also add docstring.
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2021

Codecov Report

Merging #207 (1089869) into main (9213c81) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   71.15%   71.15%           
=======================================
  Files          29       29           
  Lines        1751     1751           
=======================================
  Hits         1246     1246           
  Misses        505      505           
Impacted Files Coverage Δ
dwave_networkx/drawing/qubit_layout.py 5.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9213c81...1089869. Read the comment docs.

@arcondello arcondello merged commit e988c71 into dwavesystems:main Oct 22, 2021
@mcfarljm mcfarljm deleted the cmap branch October 22, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmap improperly referenced
3 participants