Update and improve TSP code #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 75.32% 75.38% +0.06%
==========================================
Files 26 26
Lines 1552 1556 +4
==========================================
+ Hits 1169 1173 +4
Misses 383 383
Continue to review full report at Codecov.
|
|
Lagrange parameter update and validity check resolve issue #82 by providing a better default value and returning valid routes. |
| if lagrange is None: | ||
| # if no lagrange parameter provided, set to 'average' tour length | ||
| if G.number_of_edges()>0: | ||
| lagrange = G.size(weight=weight)*G.number_of_nodes()/G.number_of_edges() |
There was a problem hiding this comment.
Could you add few words in the comment about why it makes sense to set this value for the parameter?
arcondello
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #147 and also addresses issue #103.
There may be a faster way to check route validity, but this will get the job done.