-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify vertex cover code for unyielded edges. Add support for zephyr or zephyr #297
simplify vertex cover code for unyielded edges. Add support for zephyr or zephyr #297
Conversation
…ference lnls workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits below.
Implement code review suggestions Co-authored-by: Radomir Stevanovic <[email protected]>
I think I have implemented all the review suggestions. |
Co-authored-by: Radomir Stevanovic <[email protected]>
Co-authored-by: Radomir Stevanovic <[email protected]>
… on defective Z12s (all branches). Necessary future work - write tests for _good_cover and related defect handling since tests are mostly full yield and are missing errors.
I neglected to test all of the _good_cover code, this has now been done. Note for next pull request - the tests are currently insufficient and don't execute this function (the full workflow tests work with defect free lattices), need to add new unit tests. |
|
||
import dimod | ||
from dimod.traversal import connected_components | ||
import dwave_networkx as dnx | ||
import dwave.preprocessing | ||
from dwave.samplers import SteepestDescentSolver, TreeDecompositionSolver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackraymond, some tests are failing because dwave.samplers
is not generally available for all versions of python/dimod.
For details see #284, but TL;DR: we need to drop support for dimod<0.12
in order to switch to dwave-samplers
/dwave.samplers
.
Also, to even get access to Orang / TreeDecompositionSolver
(only available as part of dwave-samplers
) -- which is a pretty compelling reason.
I'll do that in a separate PR, and then we can rebase this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lazy with my full environment testing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jackraymond, with #299 merged, your code should now work after you rebase to master
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #297 +/- ##
==========================================
- Coverage 92.09% 91.87% -0.23%
==========================================
Files 18 18
Lines 2252 2264 +12
==========================================
+ Hits 2074 2080 +6
- Misses 178 184 +6 ☔ View full report in Codecov by Sentry. |
Two enhancements:
Add support for zephyr lattices on zephyr solvers (Advantage2)
Improve handling of unyielded edges, improving performance for lower yield processors using dwave-ocean-sdk and networkx algorithms.