Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class and instance-level Client config defaults #427

Merged

Conversation

randomir
Copy link
Member

Closes #425.
Closes #113.

Core functionality of dwavesystems#425.

Note: compatibility break -- Client init now takes ONLY THREE positional
arguments (endpoint, token, solver). In the future, we want to deprecate
pos args completely.

This compat break should have **minimal** impact. Legacy code used to
provide only endpoint and token via pos args.
Note: we're still keeping `Future.clock_diff`.
Copy link
Contributor

@JoelPasvolsky JoelPasvolsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

docs/reference/resources.rst Show resolved Hide resolved
docs/reference/resources.rst Show resolved Hide resolved
dwave/cloud/client.py Outdated Show resolved Hide resolved
dwave/cloud/client.py Outdated Show resolved Hide resolved
dwave/cloud/client.py Outdated Show resolved Hide resolved
dwave/cloud/client.py Outdated Show resolved Hide resolved
dwave/cloud/client.py Outdated Show resolved Hide resolved
dwave/cloud/client.py Outdated Show resolved Hide resolved
dwave/cloud/config.py Show resolved Hide resolved
dwave/cloud/config.py Outdated Show resolved Hide resolved
Copy link
Member

@arcondello arcondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randomir randomir merged commit 277a752 into dwavesystems:master Sep 21, 2020
@randomir randomir deleted the feature/zero-level-config/issue-425 branch September 21, 2020 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants