Build wheels for Python 3.11 #1247
Conversation
arcondello
force-pushed
the
feature/Python3.11
branch
9 times, most recently
from
cf23ce0 to
357396b
Compare
|
python/cpython#29560 introduced a warning when a |
|
|
arcondello
force-pushed
the
feature/Python3.11
branch
2 times, most recently
from
6923dc9 to
d43a4de
Compare
Codecov Report
@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
+ Coverage 94.89% 95.09% +0.19%
==========================================
Files 83 83
Lines 8208 8214 +6
==========================================
+ Hits 7789 7811 +22
+ Misses 419 403 -16
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
arcondello
force-pushed
the
feature/Python3.11
branch
4 times, most recently
from
8700f8e to
1f5e24a
Compare
| @@ -404,17 +392,10 @@ workflows: | |||
| - build-linux: &build | |||
| matrix: | |||
| parameters: | |||
| python-version: &python-versions [3.7.9, 3.8.9, 3.9.4, 3.10.0] | |||
| python-version: [3.7.9, 3.8.9, 3.9.4, 3.10.0, 3.11.0] | |||
There was a problem hiding this comment.
I don't think 3.11 is released yet. Oh, I see, new cibuildwheel has an alias to rc.
There was a problem hiding this comment.
Actually, for consistency it would make sense to use 3.11.0rc1 here as well.
| @@ -450,7 +431,7 @@ workflows: | |||
| - build-windows | |||
| matrix: | |||
| parameters: | |||
| python-version: *python-versions | |||
| python-version: [3.7.9, 3.8.9, 3.9.4, 3.10.0] # no 3.11 with nuget yet | |||
There was a problem hiding this comment.
Why not use DockerHub's Windows Python image (instead of installing python with nuget -- should speed-up and simplify things), like 3.11.0rc2-windowsservercore-ltsc2022? Actually, using 3.11-rc or 3.11.0rc1 on windows executor should suffice (as these are multi-platform images, just like our ocean-docker is 😆).
There was a problem hiding this comment.
Great idea! Will look into it.
There was a problem hiding this comment.
Ok, this has turned into a hellscape of windows syntax. Specifically flavours of this. I have run out of patience so I think we should just skip 3.11 tests for now.
There was a problem hiding this comment.
You can try with shell: bash -eo pipefail.
Or yes, just skip 3.11 tests for now.
There was a problem hiding this comment.
Ok, I have it working. Now the issue is that it takes 4+min to download the docker image! I tried seeing if I can speed it up with docker save/docker load but those are also stupidly slow.
For comparison the nuget install was ~20s.
Anyway, I am sick of windows so will think more about it tomorrow.
There was a problem hiding this comment.
Yes, that's awful. 🤢 😱
I can't understand why CircleCI doesn't cache those 2GB+ docker images. I bet GitHub Actions start Windows images in seconds 😝
So, I retract my initial idea of using Windows images.
| features: | ||
| - Build wheels for Python 3.11. | ||
| upgrade: | ||
| - Build ``manylinux2014`` wheels. Previously we built ``manylinux2010``. |
There was a problem hiding this comment.
For posterity: manylinux2014 wheels require pip >= 19.3 that comes bundled with python 3.7.8+, 3.8.4+, 3.9.0+. python ~= 3.7.0,<3.7.3 with older pip hence will not pull these images without pip upgrade.
This is a slight annoyance, since upgrading pip is generally desirable (and pip itself is very aggressive in its prods to upgrade). Additionally, we'll drop 3.7 support in not too distant future (it EOLs 2023-06).
arcondello
force-pushed
the
feature/Python3.11
branch
7 times, most recently
from
dc469bb to
8195f68
Compare
arcondello
force-pushed
the
feature/Python3.11
branch
from
8195f68 to
1f5e24a
Compare
Also switch to manylinux2014.
arcondello
force-pushed
the
feature/Python3.11
branch
from
1f5e24a to
77eea92
Compare
Also switch to manylinux2014.