Fix image sampling when width x height < than 300x250 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When qr_code div element's width x height values are lower than 300 x 250, sampling process uses fixed width x height values (307 x 250) disregarding custom values defined by user. This fix removes hard-coded width x height values and uses variables instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When qr_code div element's width x height values are lower than 300 x
250, sampling process uses fixed width x height values (307 x 250)
disregarding custom values defined by user. In this case, QR reader isn't working because only part of the video is beeing captured and there is a significant loss of details.
This fix removes hard-coded width x height values and uses variables instead.