fix: remove all listeners after gesture end

this fixes deselect happening when clicking outside of the svg
dvictor · Oct 17, 2020 · 8a18483 · 8a18483
1 parent 3723f84
commit 8a18483
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/lib/demo.js b/lib/demo.js
@@ -8,6 +8,8 @@ function setData(el, data) {
     el.__data = data;
 }
 var graph = {
+    // build a doc out of what's on screen
+    // in a typical app, you'll do the other way around
     nodes: Array.from(g.children).map(function (el) {
         var m = el.transform.baseVal.getItem(0).matrix;
         var n = {

diff --git a/lib/dnd.js b/lib/dnd.js
@@ -12,6 +12,8 @@ export function dnd(onInit, onMove, onEnd) {
     var remove = function (e) {
         document.removeEventListener('touchmove', onMouseMove);
         document.removeEventListener('mousemove', onMouseMove);
+        document.removeEventListener('mouseup', remove);
+        document.removeEventListener('touchend', remove);
         onEnd(e);
     };
     function onMouseDown(e) {

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "svg-editor-tools",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "Primitives for building a browser based WYSWYG editor. Demo provided.",
   "main": "lib/index.js",
   "repository": "https://github.com/dvictor/svg-editor-tools",

diff --git a/src/dnd.ts b/src/dnd.ts
@@ -22,6 +22,8 @@ export function dnd(
 	const remove = (e: MouseEvent) => {
 		document.removeEventListener('touchmove', onMouseMove);
 		document.removeEventListener('mousemove', onMouseMove);
+		document.removeEventListener('mouseup', remove);
+		document.removeEventListener('touchend', remove);
 		onEnd(e)
 	};
 	function onMouseDown(e: MouseEvent) {