Add conversions to/from Twitter Util #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvgica
force-pushed
the
managerial-twitter-util
branch
from
29fdeb0 to
84c2a94
Compare
|
Decided to not cross-compile for Scala 3, instead relying on Scala 3's ability to use Scala 2.13 artifacts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a subproject to add compatibility between Twitter Util's Managed and Managerial Managed. Specifically it adds
tu.Managed#asManagerialandmanagerial.Managed#asTwitterUtilwhenimport ca.dvgi.managerial.twitter.util._is used.Everything works, but Twitter Util isn't released for Scala 3 yet, and cross-building the specific subproject without Scala 3 seems difficult? Not sure I want to futz around getting that to work right now. But I'll keep the code kicking around as an example and in the hopes that Twitter Util for Scala 3 becomes a thing eventually.