Skip to content
This repository has been archived by the owner on Sep 11, 2018. It is now read-only.

Added reducer blueprint #630

Closed
wants to merge 4 commits into from

Conversation

ericwooley
Copy link
Contributor

The reducers are what I use the blueprints for the most so far, figured I would contribute back my blueprint for reducers.

If you don't want a reducer blueprint, feel free to reject.

@codecov-io
Copy link

Current coverage is 48.88%

Merging #630 into master will not affect coverage as of de38535

@@            master    #630   diff @@
======================================
  Files            6       6       
  Stmts           45      45       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit             22      22       
  Partial          0       0       
  Missed          23      23       

Review entire Coverage Diff as of de38535

Powered by Codecov. Updated on successful CI builds.


beforeInstall: function (options) {},
afterInstall: function (options) {}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the boilerplate in here and the path require

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by path require, you mean line 21 - 23?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 1 of blueprints/reducers/index.js. You can have it just export an empty object since you don't need to override any of the hooks.

I think there may already be a duck blueprint that does something like this, but might be useful to have different versions of blueprints.

@dvdzkwsk
Copy link
Owner

dvdzkwsk commented Mar 8, 2016

Generic but non-automatic response: away on vacation, ty for PR, will review next Saturday/Sunday.

@dvdzkwsk
Copy link
Owner

We already have a duck reducer (naming is a bit unclear for the uninitiated), so is this needed?

@ericwooley
Copy link
Contributor Author

@davezuko I didn't realize the duck was supposed to be a reducer blueprint. And it doesn't follow the other blueprint, but meh! do as you like!

@dvdzkwsk
Copy link
Owner

I'll consider it further, but will probably drop one or the other.

Sent from my iPhone

On Mar 14, 2016, at 12:31 PM, Eric Wooley [email protected] wrote:

@davezuko I didn't realize the duck was supposed to be a reducer blueprint. And it doesn't follow the other blueprint, but meh! do as you like!


Reply to this email directly or view it on GitHub.

@dvdzkwsk
Copy link
Owner

This will be changing with #684. Thanks for the contribution though, much appreciated!

@dvdzkwsk dvdzkwsk closed this Apr 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants