Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support citations from both bibliography and export formats #2

Merged
merged 5 commits into from
Oct 7, 2021

Conversation

dvanoni
Copy link
Owner

@dvanoni dvanoni commented Oct 7, 2021

Fixes #1

Citations were failing to generate when the default Quick Copy format was set to an export mode rather than a bibliography mode. This PR adds support for export mode by providing the required callback to Zotero.QuickCopy.getContentFromItems().

@dvanoni dvanoni self-assigned this Oct 7, 2021
@dvanoni dvanoni merged commit 40bbb99 into main Oct 7, 2021
@dvanoni dvanoni deleted the issue-1 branch October 7, 2021 04:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

🤖 this is your friendly neighborhood build bot announcing test build 0.1.1.11 ("Merge pull request #2 from dvanoni/issue-1\n\nSupport citations from both bibliography and export formats")

Install in Zotero by downloading test build 0.1.1.11, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Failed to save item(s) to Notion TypeError: content.text is undefined
1 participant