Fix problem with running plasmoid in plasmas native X11 enviroment #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I stumbled upon a problem with my KDE Plasma/I3 setup, when I tried to log into a session using the original X11 enviroment after installing i3-pager. This caused the whole login procedure to crash, which was a bit of a problem. I figured out that the problem laid in i3ipcpp and not this plugin. I made a fix for it and made a pull request to i3ipcpp.
This fix results in some other problems in the i3-pager plasmoid though. As the fix got everything running as it should, multiple calls to open files started to be made even though all calls failed (as I was using the wrong window manager). This eventually resulted in no more file calls to be accepted from any plasma process, crashing the whole desktop enviroment.
I fixed this by making the plasmoid stop if it didn't succeed with the calls. I have tested it in both window managers and it doesn't seem to break anything.
I would appreciate if you would like to consider my pull request. Thanks in advance.