Handle (in)significant whitespace in className (enzymejs#348)

dustinsanders · Apr 30, 2016 · fdc060e · fdc060e
1 parent 9913d0f
commit fdc060e
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 2 deletions.
diff --git a/src/MountedTraversal.js b/src/MountedTraversal.js
@@ -49,7 +49,8 @@ export function instHasClassName(inst, className) {
   if (!isDOMComponent(inst)) {
     return false;
   }
-  const classes = findDOMNode(inst).className || '';
+  let classes = findDOMNode(inst).className || '';
+  classes = classes.replace(/\s/g, ' ');
   return ` ${classes} `.indexOf(` ${className} `) > -1;
 }
 

diff --git a/src/ShallowTraversal.js b/src/ShallowTraversal.js
@@ -26,7 +26,8 @@ export function childrenOfNode(node) {
 }
 
 export function hasClassName(node, className) {
-  const classes = propsOfNode(node).className || '';
+  let classes = propsOfNode(node).className || '';
+  classes = classes.replace(/\s/g, ' ');
   return ` ${classes} `.indexOf(` ${className} `) > -1;
 }
 

diff --git a/test/ReactWrapper-spec.js b/test/ReactWrapper-spec.js
@@ -887,6 +887,23 @@ describeWithDOM('mount', () => {
       expect(wrapper.is('.foo.bar')).to.equal(true);
     });
 
+    it('should ignore insignificant whitespace', () => {
+      const className = `
+      foo
+      `;
+      const wrapper = mount(<div className={className} />);
+      expect(wrapper.is('.foo')).to.equal(true);
+    });
+
+    it('should handle all significant whitespace', () => {
+      const className = `foo
+
+      bar
+      baz`;
+      const wrapper = mount(<div className={className} />);
+      expect(wrapper.is('.foo.bar.baz')).to.equal(true);
+    });
+
     it('should return false when selector does not match', () => {
       const wrapper = mount(<div className="bar baz" />);
       expect(wrapper.is('.foo')).to.equal(false);

diff --git a/test/ShallowWrapper-spec.js b/test/ShallowWrapper-spec.js
@@ -996,6 +996,22 @@ describe('shallow', () => {
       expect(wrapper.is('.foo.bar')).to.equal(true);
     });
 
+    it('should ignore insignificant whitespace', () => {
+      const className = `foo
+      `;
+      const wrapper = shallow(<div className={className} />);
+      expect(wrapper.is('.foo')).to.equal(true);
+    });
+
+    it('should handle all significant whitespace', () => {
+      const className = `foo
+
+      bar
+      baz`;
+      const wrapper = shallow(<div className={className} />);
+      expect(wrapper.is('.foo.bar.baz')).to.equal(true);
+    });
+
     it('should return false when selector does not match', () => {
       const wrapper = shallow(<div className="bar baz" />);
       expect(wrapper.is('.foo')).to.equal(false);