-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination #45
Pagination #45
Conversation
This is just waiting on docs, right? |
Yeah. I'm hoping to have time for this later in the week. |
Ok, I found some time to do a first version of the docs. I've asked for contributions for docs about integration with ember-cli-pagination since I don't have time to figure it out right now. Feel free to give the docs a thorough edit for style, tone, bad grammar or whatever. I won't be offended. :) |
I need to add an entry in the Changelog. I'll do that right now. |
|
||
```js | ||
if (meta.next) { | ||
store.find('post', {page: meta.next} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a closing paren here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I just fixed it.
Documentation looks good. I left a couple nitpicking comments. |
I've updated the documentation. I added all of your corrections and added a new section about the page size that I need to finish once we have thing solidified. |
The two things remaining:
|
After some thought, I think including the |
Ok, I've re-worked the docs for page_size. @dustinfarris Can you look at the pagination docs one more time? |
👍 |
This PR is taking over from #38 because it's not possible edit the destination branch. The PR was originally against the version-1.0 branch which has now been merged into master.