Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs sId/cId wording changes #9780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs sId/cId wording changes #9780

wants to merge 1 commit into from

Conversation

albandum
Copy link
Contributor

@albandum albandum commented Jan 7, 2025

Description

Quick wording changes

Risk

Deploy Plan

@albandum albandum requested a review from overmode January 7, 2025 08:46
Copy link
Contributor

devloai bot commented Jan 7, 2025

Automatic code review is enabled for this repository. I will perform a review of this PR.

Copy link
Contributor

@devloai devloai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the documentation wording changes. While the ID → Id standardization looks good, I found a systematic issue where conversation ID parameters (denoted by cId) are incorrectly described as "sId" in several files. I've added specific suggestions to fix these inconsistencies.

* schema:
* type: string
* - in: path
* name: cId
* required: true
* description: ID of the conversation
* description: sId of the conversation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter is cId (conversation ID) but the description incorrectly says "sId". This should be "cId" instead.

Suggested change
* description: sId of the conversation
* description: cId of the conversation

@@ -31,7 +31,7 @@ import { apiError } from "@app/logger/withlogging";
* required: true
* schema:
* type: string
* description: Conversation ID
* description: Conversation sId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter is cId (Conversation ID) but the description incorrectly says "Conversation sId". This should be "Conversation cId" for consistency.

Suggested change
* description: Conversation sId
* description: Conversation cId

@@ -30,7 +30,7 @@ import { apiError } from "@app/logger/withlogging";
* required: true
* schema:
* type: string
* description: Conversation ID
* description: Conversation sId
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter is cId (Conversation ID) but the description incorrectly says "Conversation sId". This should be "Conversation cId" for consistency.

Suggested change
* description: Conversation sId
* description: Conversation cId

* schema:
* type: string
* - in: path
* name: cId
* required: true
* description: ID of the conversation
* description: sId of the conversation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter is cId (conversation ID) but the description incorrectly says "sId". This should be "cId" instead.

Suggested change
* description: sId of the conversation
* description: cId of the conversation

Copy link

github-actions bot commented Jan 7, 2025

Fails
🚫

Files in **/api/v1/ have been modified. Please add the documentation-ack label to acknowlegde that if anything changes
in a public endpoint, you need to edit the JSDoc comment
above the handler definition and/or the swagger_schemas.ts file and regenerate the documentation using npm run docs

Generated by 🚫 dangerJS against 02d4a4d

Copy link
Contributor

@overmode overmode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants