Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorize upsert_table use-case on public API if system key #10595

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Feb 6, 2025

Description

Authorize upsert_table file creation and upload on the public API if called by a system key.

Tests

Added a test

Risk

Very low

Deploy Plan

  • Deploy front

Copy link

github-actions bot commented Feb 6, 2025

Warnings
⚠️

Files in **/api/v1/ have been modified and the PR has the documentation-ack label.
Don't forget to run npm run docs and use the Deploy OpenAPI Docs Github action to update https://docs.dust.tt/reference.

Generated by 🚫 dangerJS against 93db7d1

@spolu spolu added documentation-ack Used to acknowledge that documentation is up-to-date with this PR sdk-ack Used to acknowledge that you are not breaking the public API. labels Feb 6, 2025
@spolu spolu requested a review from Fraggle February 6, 2025 16:03
Copy link
Contributor

@Fraggle Fraggle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (more tests yeah !)

FYI, another test case to make sure it works as expected for the other use case with a system key ? (fyi createPublicApiMockRequest() has a systemKey param)

And maybe another one to check that we refuse random useCase values ?

@spolu
Copy link
Contributor Author

spolu commented Feb 6, 2025

Fine I'll add those Mr. Test

@spolu spolu merged commit d7c3622 into main Feb 10, 2025
9 checks passed
@spolu spolu deleted the spolu-api_tweaks branch February 10, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation-ack Used to acknowledge that documentation is up-to-date with this PR sdk-ack Used to acknowledge that you are not breaking the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants