Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHANGELOG issue links #693

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Fix CHANGELOG issue links #693

merged 1 commit into from
Jun 15, 2022

Conversation

moCello
Copy link
Member

@moCello moCello commented Jun 14, 2022

Resolves: #688

@moCello moCello self-assigned this Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #693 (d24ff39) into master (f5fa056) will decrease coverage by 1.35%.
The diff coverage is 98.48%.

❗ Current head d24ff39 differs from pull request most recent head 6e71182. Consider uploading reports for the commit 6e71182 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #693      +/-   ##
==========================================
- Coverage   82.03%   80.68%   -1.36%     
==========================================
  Files          54       47       -7     
  Lines        4437     3505     -932     
==========================================
- Hits         3640     2828     -812     
+ Misses        797      677     -120     
Impacted Files Coverage Δ
src/constraint_system/constraint.rs 32.91% <ø> (+0.81%) ⬆️
...raint_system/ecc/curve_addition/fixed_base_gate.rs 100.00% <ø> (ø)
...nt_system/ecc/curve_addition/variable_base_gate.rs 93.75% <ø> (ø)
src/constraint_system/logic.rs 93.02% <ø> (ø)
src/constraint_system/range.rs 73.07% <ø> (ø)
src/error.rs 0.00% <ø> (-7.15%) ⬇️
src/lib.rs 100.00% <ø> (ø)
src/permutation.rs 89.54% <ø> (-0.25%) ⬇️
src/proof_system/linearization_poly.rs 99.30% <ø> (-0.20%) ⬇️
src/proof_system/quotient_poly.rs 98.52% <ø> (-0.35%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebc95c...6e71182. Read the comment docs.

@moCello moCello force-pushed the mocello/changelog branch from 0f25542 to af36551 Compare June 15, 2022 07:56
@moCello moCello force-pushed the mocello/changelog branch from af36551 to 6e71182 Compare June 15, 2022 09:07
@moCello moCello requested a review from t00ts June 15, 2022 09:15
Copy link
Contributor

@t00ts t00ts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@moCello moCello merged commit 6e71182 into master Jun 15, 2022
@moCello moCello deleted the mocello/changelog branch June 15, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CHANGELOG
2 participants