-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the reference document link #533
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR!
LGTM but the toolchain needs to be changed to match
Line 1 in 65e1a51
nightly-2021-06-06 |
Also, please add the changes under |
Hi @CPerezz |
Hi, all seems nice. I'd maybe ask for an edit of the commit message of e38fe5c to something like: For the rest, looks fine!
You can use Github Discussions!! We don't have any other places that I'm aware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please, address:
Hi, all seems nice. I'd maybe ask for an edit of the commit message of e38fe5c to something like: Update CHANGELOG.md. Which follows the same format as the others.
Once addressed, this can be merged!!
Thanks for your contribution! 😄
Hi @CPerezz |
Hi there!
I modified the document link and fixed some typos.
When I click the document link, there is a 404 error so I set the link about it.
But I don't know about the other bellow three documents link.
And when I ran
$make doc
command the error happened because of the toolchain version problem.The error is following and the issue is here.
Please confirm.
Thank you!