Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and add tests for component_range #735

Closed
moCello opened this issue Feb 7, 2023 · 1 comment · Fixed by #747
Closed

Refactor and add tests for component_range #735

moCello opened this issue Feb 7, 2023 · 1 comment · Fixed by #747
Assignees

Comments

@moCello
Copy link
Member

moCello commented Feb 7, 2023

Describe what you want implemented
Add in-circuit tests for the composer methods

  • component_range

Describe "Why" this is needed
Increase test coverage

Describe alternatives you've considered
N/A

Additional context
Continuation of #731

@moCello
Copy link
Member Author

moCello commented Mar 14, 2023

Turns out that no constraint is added when num_bits = 0. This means that a circuit that constraints a witness to be encoded in 0 bits will always pass. This is an edge case but should be fixed nonetheless. See issue #746

moCello added a commit that referenced this issue Mar 14, 2023
@moCello moCello mentioned this issue Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant