Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should not pass if the benchmarks are broken #610

Closed
ZER0 opened this issue Oct 8, 2021 · 0 comments · Fixed by #614
Closed

CI should not pass if the benchmarks are broken #610

ZER0 opened this issue Oct 8, 2021 · 0 comments · Fixed by #614
Assignees
@ureeves
Labels
team:Core Low Level Core Development Team (Rust)
Milestone
Implementing PlonkUp

Comments

@ZER0
Copy link
Contributor

ZER0 commented Oct 8, 2021

Describe what you want implemented
The CI should prevent a PR to be merged if it breaks the benchmark.

Describe "Why" this is needed
Benchmark should be able to compile and run.

Describe alternatives you've considered
N/A

Additional context
This could be easily implemented in the CI with a generic cargo check --all-targets.
@ZER0 ZER0 added this to the Implementing PlonkUp milestone Oct 8, 2021
@ZER0 ZER0 changed the title CI should not pass if the benchmark are broken CI should not pass if the benchmarks are broken Oct 8, 2021
@ZER0 ZER0 added the team:Core Low Level Core Development Team (Rust) label Oct 8, 2021
@ureeves ureeves self-assigned this Oct 11, 2021
@ureeves ureeves mentioned this issue Oct 11, 2021
Merged
@ureeves ureeves linked a pull request Oct 12, 2021 that will close this issue
Fix benches and make CI fail if they don't compile #614
Merged
ureeves added a commit that referenced this issue Oct 13, 2021
@ureeves
Add cargo check --all-targets to CI
3d3c32b 
Resolves: #610
ureeves added a commit that referenced this issue Oct 13, 2021
@ureeves
Fix benches and make CI fail if they don't compile (#614)
5748ed8 
* Add `cargo check --all-targets` to CI
* Fix bench compilation

Resolves: #610
Resolves: #609
@ureeves ureeves closed this as completed Oct 14, 2021
vlopes11 pushed a commit that referenced this issue Oct 18, 2021
@ureeves @vlopes11
Fix benches and make CI fail if they don't compile (#614)
d39bdb5 
* Add `cargo check --all-targets` to CI
* Fix bench compilation

Resolves: #610
Resolves: #609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ureeves ureeves

Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
Implementing PlonkUp
Development

Successfully merging a pull request may close this issue.

Fix benches and make CI fail if they don't compile dusk-network/plonk
2 participants
@ZER0 @ureeves