Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce the public visibility of Structs modules and internal fields that are non needed to expose #438

Closed
CPerezz opened this issue Mar 5, 2021 · 0 comments
Closed

Reduce the public visibility of Structs modules and internal fields that are non needed to expose #438

CPerezz opened this issue Mar 5, 2021 · 0 comments
Assignees
@CPerezz
Labels
team:Core Low Level Core Development Team (Rust)

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Mar 5, 2021

Currently, we expose a way too much things when indeed we should try to expose publicly in the API only the necessary stuff.

We have modules as fft or transcript_protocol which shouldn't be pub.
Also there are quite some structures which are pub but never meant to be used by the lib consumers.

Finally we also have pub fields for structs like Proof when indeed they shouldn't be.
@CPerezz CPerezz added the team:Core Low Level Core Development Team (Rust) label Mar 5, 2021
@CPerezz CPerezz self-assigned this Mar 5, 2021
@CPerezz CPerezz mentioned this issue Mar 5, 2021
Closed
CPerezz pushed a commit that referenced this issue Mar 5, 2021
Cut visibility of crate structures & fn's
84a1111 
Currently, we expose a way too much things when indeed we should try
to expose publicly in the API only the necessary stuff.

We have modules as fft or transcript_protocol which shouldn't be pub.
Also there are quite some structures which are pub but never meant to
be used by the lib consumers.

The idea is that with this PR we're able to make more clear which are
the things that the consumer is suposed to call or do.

Closes #438
@CPerezz CPerezz mentioned this issue Mar 5, 2021
Merged
CPerezz pushed a commit that referenced this issue Mar 8, 2021
Cut visibility of crate structures & fn's
7112723 
Currently, we expose a way too much things when indeed we should try
to expose publicly in the API only the necessary stuff.

We have modules as fft or transcript_protocol which shouldn't be pub.
Also there are quite some structures which are pub but never meant to
be used by the lib consumers.

The idea is that with this PR we're able to make more clear which are
the things that the consumer is suposed to call or do.

Closes #438
@CPerezz CPerezz mentioned this issue Mar 11, 2021
Merged
@ZER0 ZER0 closed this as completed in 8e431bf Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CPerezz