Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HashMap by hashbrown::HashMap #424

Closed
CPerezz opened this issue Mar 3, 2021 · 0 comments
Closed

Replace HashMap by hashbrown::HashMap #424

CPerezz opened this issue Mar 3, 2021 · 0 comments
Assignees
@CPerezz
Labels
team:Core Low Level Core Development Team (Rust)

Comments

@CPerezz
Copy link
Contributor

CPerezz commented Mar 3, 2021

Since we're moving towards no_std and it's also known that the std lib HashMap does not perform as fast as other implementations, we should consider to replace all of the HashMap usages of this lib to use https://github.com/rust-lang/hashbrown HashMap instance.
@CPerezz CPerezz added type:performance team:Core Low Level Core Development Team (Rust) labels Mar 3, 2021
@CPerezz CPerezz self-assigned this Mar 3, 2021
CPerezz pushed a commit that referenced this issue Mar 8, 2021
Use hashbrown::HashMap instead of collections::HashMap
ceff9ed 
Closes #424
@CPerezz CPerezz mentioned this issue Mar 8, 2021
Merged
CPerezz pushed a commit that referenced this issue Mar 8, 2021
Replace collections::HashMap for hashbrown::HashMap
40c45bf 
Resolves: #424
@CPerezz CPerezz mentioned this issue Mar 11, 2021
Merged
@ZER0 ZER0 closed this as completed in 8e431bf Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
team:Core Low Level Core Development Team (Rust)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CPerezz