Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change finalize to return the hash directly #262

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Change finalize to return the hash directly #262

merged 1 commit into from
Apr 18, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Apr 17, 2024

Resolves #259

@moCello moCello force-pushed the mocello/259_finalize branch from 3004d0c to 6f29fe0 Compare April 17, 2024 13:27
@moCello moCello force-pushed the mocello/259_finalize branch from 6f29fe0 to ebb207e Compare April 17, 2024 13:32
ureeves
ureeves approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@moCello moCello merged commit 4e209f1 into master Apr 18, 2024
6 checks passed
@moCello moCello deleted the mocello/259_finalize branch April 18, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ureeves ureeves ureeves approved these changes

@xevisalle xevisalle xevisalle approved these changes

@ZER0 ZER0 Awaiting requested review from ZER0

@HDauven HDauven Awaiting requested review from HDauven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let finalize return the hash directly and not wrapped into a Result
3 participants
@moCello @xevisalle @ureeves