Deepesh kalura/issue507 #553
Conversation
Fixes duolicious#507 by adding robot to app.tsx and then chaning the default-text.tsx and default-text-input.tsx
There was a problem hiding this comment.
I haven't tested it yet but it looks good so far. Obviously Montserrat needs to be removed, as you mentioned.
Could you also avoid making formatting changes in this PR? I'm okay with formatting changes, but in a separate PR. It'd be a PR which adds linting to CI.
|
Also, I'm not sure a lot of these Roboto fonts are needed. Just the ones loaded in |
Co-authored-by: duogenesis <[email protected]>
|
@duogenesis I have automatically linter enable we can discuss about this linter what we can do |
ok got it |
|
@duogenesis i think all done |
|
@DeepeshKalura looking good so far. Just needs to avoid making those unrelated linting changes, then I'll check it out, test it locally, and hopefully merge. Does it look okay to you on a web browser? |
|
@duogenesis small i commit those change refactor change and how we are going to move forward with the about linters |
|
@duogenesis lol i didn't run locally i just predict and and do such changes if there will be some I am unable to notice all of fonts are same for me. Next time I will check locally as well in android. I don't have mac so no ios ok |
In the way I've described a couple times already? 🙂 Is the problem that you don't want to disable linting in your IDE because it's inconvenient to toggle it on and off for the different projects you're working on? Again, I'm completely open to adopting your linting preferences, but that'd be a separate PR to enforce them in CI. |
|
@duogenesis The problem is i am using vscode I don't know which linter I am using I have no idea for web or javascript. I know about python or I know about the dart but absolutely clueless. So, we can make a strategy to use the same linter. As, I mention I am currently unemployed so I only worked on freelance project or personal project. There I don't mind switching to anylinter. Let me open new issue and there we can discuss which linter we will use for this project.
I know I download this linter for my personal project after that I never think off |
|
@duogenesis does this PR left anything or there is a flow which I was missing. Can you tell me ?? |
|
@DeepeshKalura Sorry, I've been busy. I'll merge it in the next day or two |
|
@duogenesis hey mate nor be sorry to me ok. I am not doing any favor to you know, rather we can enjoy coding |
App.tsx
Outdated
| RobotoMedium: require('./assets/fonts/roboto/Roboto-Medium.ttf'), | ||
| RobotoRegular: require('./assets/fonts/roboto/Roboto-Regular.ttf'), | ||
| RobotoSemiBold: require('./assets/fonts/montserrat/static/Roboto-SemiBold.ttf'), | ||
| RobotoThin: require('./assets/fonts/roboto/Roboto-Thin.ttf'), |
There was a problem hiding this comment.
I just checked out your branch. It turns out these paths are all incorrect. They're missing /static/ but some are missing other things too. However after fixing that, the fonts still don't seem to work for some elements. If you search for Monterrat in the components directory, you'll see why. I fixed those issues locally, but now that I'm looking at Roboto on the login screen, I don't really like it. It also occurs to me that font sizes throughout the app could need changing, so this PR could be harder than expected. If you're willing to still try a few different fonts, and screencap how they look on the login screen for discussion in this PR, I'd be open to that. Here's Roboto. Supposedly the "Cute dates" tagline is written with a font weight of 900, though it still isn't anywhere near as heavy as Montserrat.
There was a problem hiding this comment.
I like the font used on Discord's home page (ABC Ginto Nord), though it needs a license
There was a problem hiding this comment.
@duogenesis Ok OK, I got it.
I don't get a heavy what does it mean! Can you elaborate more.
So, then my actions will be super weird too.
Yeah it seem harder because it has lots of choice which depends upon feeling. Anyway what I can do looks for alternate of the discord feeling fonts then choose one which is even readable I will send images here so you can choose one.
Sounds good
There was a problem hiding this comment.
@duogenesis yeah also push roboto changes to this issue branch ok so I can check what changes you did it will be easily for me not do same mistake again
Fixes duolicious#507 missing static and resolve the error for roboto fonts
|
@duogenesis Hello brother, Arvo Bold
Roboto Bold
Does any look good?? I have list which looks similar to the Discord text: https://fonts.google.com/specimen/Oswald see from any of these did you like if not like by above ones |
|
As mentioned on #507, it's not really possible to do this ticket properly without better support from React Native for fallback fonts, so I'm going to close this PR for now. |
by adding robot to app.tsx and then chaning the default-text.tsx and default-text-input.tsx