Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test png icon if svg fails to load #1329

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

bynect
Copy link
Member

@bynect bynect commented Apr 9, 2024

Made valid.png 16x16 to be consistent with valid.svg and reworked notification_load_icon_with_scaling to use png if svg fails to load (this is due the missing librsvg which is a runtime dependency)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 65.68%. Comparing base (07b68f0) to head (f107bba).
Report is 3 commits behind head on master.

Files Patch % Lines
test/notification.c 61.53% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
- Coverage   65.71%   65.68%   -0.03%     
==========================================
  Files          50       50              
  Lines        8041     8047       +6     
  Branches      925      928       +3     
==========================================
+ Hits         5284     5286       +2     
- Misses       2757     2761       +4     
Flag Coverage Δ
unittests 65.68% <61.53%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect merged commit a15bc5a into dunst-project:master Apr 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants