Fix logging in icon code

[bynect]

Remove extra newlines and move a string empty upwards

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.79%. Comparing base (b6a8a19) to head (9a9c74a).
Report is 13 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
+ Coverage   64.46%   64.79%   +0.32%     
==========================================
  Files          48       48              
  Lines        7920     7962      +42     
==========================================
+ Hits         5106     5159      +53     
+ Misses       2814     2803      -11     

Flag	Coverage Δ
unittests	64.79% <100.00%> (+0.32%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Rentib]

Was it expected that setting default_icon = "" uses an icon?

[urgency_normal]
  timeout = 10
  default_icon = ""

This for example still uses an icon for notifications with normal urgency.
The icon used is the default one.

[bynect]

Was it expected that setting default_icon = "" uses an icon?

[urgency_normal]
  timeout = 10
  default_icon = ""

This for example still uses an icon for notifications with normal urgency. The icon used is the default one.

What do you mean it uses the default icon? Also could you please open an issue

Also, is this something that happened after this commit?

[Rentib]

Was it expected that setting default_icon = "" uses an icon?

[urgency_normal]
  timeout = 10
  default_icon = ""

This for example still uses an icon for notifications with normal urgency. The icon used is the default one.

What do you mean it uses the default icon? Also could you please open an issue

Also, is this something that happened after this commit?

If you specify icon_theme in configuration file, then for all notifications dunst will use an icon from the theme, unless you configure it otherwise. If you check for example Papirus icons then dunst will use emblem-information icon I think.

Example config:

[global]
  enable_recursive_icon_lookup = true
  icon_theme = "Adwaita, Papirus"

[bynect]

Was it expected that setting default_icon = "" uses an icon?

[urgency_normal]
  timeout = 10
  default_icon = ""

This for example still uses an icon for notifications with normal urgency. The icon used is the default one.

What do you mean it uses the default icon? Also could you please open an issue

Also, is this something that happened after this commit?

If you specify icon_theme in configuration file, then for all notifications dunst will use an icon from the theme, unless you configure it otherwise. If you check for example Papirus icons then dunst will use emblem-information icon I think.

Example config:

[global]
  enable_recursive_icon_lookup = true
  icon_theme = "Adwaita, Papirus"

I don't get this behavior. Please open an issue including your dunst version and dunstrc so that I can investigate