Assert that notification icon is not null in tests

[bynect]

This is a temporary fix to #1228 until we figure out what causes the issue in first place (icons not being loaded).

This simply adds assertion so that if the icon is null the test suite will not segfault

The ci will fail...

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2fcea84) 65.45% compared to head (417dae3) 65.47%.

❗ Current head 417dae3 differs from pull request most recent head a3bfee8. Consider uploading reports for the commit a3bfee8 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1269      +/-   ##
==========================================
+ Coverage   65.45%   65.47%   +0.02%     
==========================================
  Files          46       46              
  Lines        7749     7754       +5     
==========================================
+ Hits         5072     5077       +5     
  Misses       2677     2677              

Flag	Coverage Δ
unittests	65.47% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bynect]

The ci actually failed with another error unrelated to the changes and is not reproducible locally...
quite the mystery

[fwsmit]

I think the memory leak was addressed by @zappolowski in #1274

[fwsmit]

This change seems fine to me. Although the tests will probably not pass locally for you now then?

[bynect]

This change seems fine to me. Although the tests will probably not pass locally for you now then?

Yes they fail but I still don't know why... but at least no segfault

[apprehensions]

It is a better idea to skip the test if the icon is missing.

[bynect]

It is a better idea to skip the test if the icon is missing.

do you know how to do that? I am not an expert of greatest

[fwsmit]

It should be SKIP()