High CPU usage when show_age_threshold = -1 #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The show_age_threshold can be set to -1 to disable the feature that updates notifications with their age. In this scenario the queues_get_next_datachange may return -1 to indicate that there is no next wakeup time (e.g. when there are permanent / critical notifications). The code that calls queues_get_next_datachange should take this scenario into account and not schedule another timeout if -1 is returned.
|
I included some slight refactoring to simplify the code a bit. If you don't like this then I can revert to just returning when |
|
Thanks, looks good to me. The simplification makes sense to me as well |
This was referenced Apr 16, 2023
myme
added a commit
to myme/dotfiles
that referenced
this pull request
Apr 19, 2023
See: dunst-project/dunst#1164 This should be removed once this fix is in an upcoming release.
myme
added a commit
to myme/dotfiles
that referenced
this pull request
Aug 1, 2023
dunst-project/dunst#1164 has now been released as dunst v1.9.2 and there's no reason for running with my own patched version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The show_age_threshold can be set to -1 to disable the feature that updates notifications with their age.
In this scenario the
queues_get_next_datachangemay return -1 to indicate that there is no next wakeup time (e.g. when there are permanent / critical notifications).The code that calls
queues_get_next_datachangeshould take this scenario into account and not schedule another timeout if -1 is returned.Addresses #1163.