Update to Rust 1.54.0 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to merge later on
So we don't have to make breaking changes every time we want to merge upstream changes.
For example, Debug on IpAddr was derived instead of being implemented as a forward to Display
Closed
|
Merged manually due to not understanding how github's fix conflicts helper is supposed to be used. |
|
thanks again for your contributions! I just released them as v0.6.0 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #12 and #13, changes in this PR can be seen here.
Updates the implementation in this crate to match the one in the latest Rust
1.54.0(from here). Also adds the tests from there.Notable remaining differences include:
const fnin this crateToSocketAddrsis not implemented for some (rather important) types that would requireallocandLookupHostToSocketAddrs::to_socket_addrsreturns custom error type instead ofstd::io::ErrorAddrParseErrordoesn't implementstd::error::Error