Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zereox - v2 macro replacements 2 #7168

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

RantumBits
Copy link
Contributor

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

[...]


quick links for more information:

@RantumBits RantumBits changed the title V2 macros2 zereox - v2 macro replacements 2 Nov 20, 2024
@jeff-dude jeff-dude added WIP work in progress dbt: dex covers the DEX dbt subproject labels Nov 20, 2024
@RantumBits
Copy link
Contributor Author

RantumBits commented Nov 27, 2024

@jeff-dude i got this updated v2 macro to run successfully. there was an issue with a invalid taker value internally in some cases that i didn't catch for a while. i've implemented a few enhancements - lmk if you see room for anything further.

@RantumBits RantumBits marked this pull request as ready for review November 27, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dbt: dex covers the DEX dbt subproject WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants