Remove price for old GALA token #6541
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes an entry associating the address of the old GALA token with prices of the new GALA token. The (new) GALA token, which has a price on coinpaprika, has address 0xd1d2eb1b1e90b638588728b4130137d262c87cae. The old GALA token has address 0x15d4c048f83bd7e37d49ea4c83a07267ec4203da. The old token trades at significantly less than the new token. Using the price of the new token for the old token is therefore not correct. The entry which is removed in this PR created a connection of the old GALA token to prices of the new token by tagging the old token with the coinpaprica token id gala-gala of the new token. This PR removes this association. It should result in removing the wrong price of the old GALA token.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
Workflow run id 10349723019 approved. |
|
Workflow run id 10349722894 approved. |
|
Workflow run id 10349723056 approved. |
|
I have read the CLA Document and I hereby sign the CLA |
Hosuke
reviewed
Aug 12, 2024
dbt_subprojects/tokens/models/prices/ethereum/prices_ethereum_tokens.sql
Show resolved
Hide resolved
jeff-dude
added
in review
jeff-dude
approved these changes
Aug 12, 2024
jeff-dude
added
ready-for-merging
and removed
in review
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Dune Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution type
Please check the type of contribution this pull request is for:
The prices of the new and old token are the same on Dune, which is not correct.