Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross chain ERC20 and NFT tokens spells #1504

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Cross chain ERC20 and NFT tokens spells #1504

merged 4 commits into from
Sep 5, 2022

Conversation

soispoke
Copy link
Contributor

@soispoke soispoke commented Sep 5, 2022

Brief comments on the purpose of your changes:
Similar to what was done for aggregators, this PR creates crosschain tokens spells, add a blockchain column to these spells, and makes sure spells that reference tokens are modified accordingly.

https://dune.height.app/T-16162

For Dune Engine V2
I've checked that:
General checks:

  • I tested the query on dune.com after compiling the model with dbt compile (compiled queries are written to the target directory)
  • I used "refs" to reference other models in this repo and "sources" to reference raw or decoded tables
  • if adding a new model, I added a test
  • the filename is unique and ends with .sql
  • each sql file is a select statement and has only one view, table or function defined
  • column names are lowercase_snake_cased
  • if adding a new model, I edited the dbt project YAML file with new directory path for both models and seeds (if applicable)
  • if adding a new model, I edited the alter table macro to display new database object (table or view) in UI explorer
  • if adding a new materialized table, I edited the optimize table macro

Join logic:

  • if joining to base table (i.e. ethereum transactions or traces), I looked to make it an inner join if possible

Incremental logic:

  • I used is_incremental & not is_incremental jinja block filters on both base tables and decoded tables
    • where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to base table (i.e. ethereum transactions or traces), I applied join condition where block_time >= date_trunc("day", now() - interval '1 week')
  • if joining to prices view, I applied join condition where minute >= date_trunc("day", now() - interval '1 week')

@soispoke soispoke merged commit 18ef656 into main Sep 5, 2022
@soispoke
Copy link
Contributor Author

soispoke commented Sep 5, 2022

thansk @aalan3

@soispoke soispoke deleted the fix-typo-tokens branch September 6, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants