Use GNU tar on Darwin to fix build error #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not just binaries, we would need to copy all source code as well. I think this fix is good enough for now. |
|
Thank you for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS
tardoesn't support the--transformflag, but one can install the GNU version of it viabrew install gnu-tarand call it viagtar. So all I did was to replacetarwithgtaron macOS.I'm not sure if this is a good solution as it involves installation of external dependency and having Homebrew installed as well. Perhaps a better fix would be to create a
$(NAMEVER)directory, copy binaries there and tar that directory instead for maximum cross-compatibility.