Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update instructions for caching with Docker #484

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

hsellik
Copy link
Contributor

@hsellik hsellik commented Nov 28, 2024

In this PR:

  • As Docker build arguments are persisted in the final image, recommend using Docker secret for the TURBO_TOKEN in docs when using remote cache for building other images.

Issues reference:

PS

  • I have not yet tested the exact commands, but I am using Turborepo Remote Cache with Docker secrets.

As Docker build arguments are persisted in the final image,
recommend using Docker secret for the TURBO_TOKEN.
@matteovivona matteovivona self-requested a review November 29, 2024 10:13
@matteovivona
Copy link
Contributor

@all-contributors add @hsellik on docs

Copy link
Contributor

@matteovivona

I've put up a pull request to add @hsellik! 🎉

@matteovivona matteovivona added the documentation Improvements or additions to documentation label Nov 29, 2024
@matteovivona matteovivona merged commit 184e008 into ducktors:main Nov 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants