-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop setup.py #58
Drop setup.py #58
Conversation
This is blocked on pypa/setuptools#1515, since we to either invoke the |
This is also blocked on pypa/pip#6041, for an equivalent to |
Whoops, didn't mean to close it. >.> |
It looks like the pep517 package provides this:
and
I think I'll experiment with making a little tool built on top of pep517+twine+the zipapp module which provides a coherent interface for wheel/sdist/zipapp builds and releasing wheel/sdist to pypi. |
@duckinator TBH, in the current state of things, the “small tool” could literally be a shell script calling |
@nbraud when you have a moment, could you rebase this? ❤️ (no rush, since we can't merge it yet, just would like a more accurate diff to see what the state of it is~) |
pypa/setuptools#1675 made it optional, and was merged in v40.9.0.
@duckinator Done; for what it's worth, you could also have done it, since PRs have “Allow edits from maintainers” checked by default, and there couldn't have been any conflict. |
Okay, nice, this PR is down to just locking down the setuptools version and removing setup.py like I thought it would be. :3 |
136: Remove setup.py. r=duckinator a=duckinator Replaces and closes #58. Original description for #58: > Followup on #55. > > - [x] Get rid of `setup.py`, which was made optional by pypa/setuptools#1675. > - [x] Set a version requirement for `setuptools`. Co-authored-by: Nicolas Braud-Santoni <[email protected]> Co-authored-by: Ellen Marie Dash <[email protected]>
Followup on #55.
setup.py
, which was made optional by Add support for setup.cfg-only projects pypa/setuptools#1675.setuptools
.