Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop setup.py #58

Closed
wants to merge 3 commits into from
Closed

Drop setup.py #58

wants to merge 3 commits into from

Conversation

nbraud
Copy link
Collaborator

@nbraud nbraud commented Jun 22, 2019

Followup on #55.

@nbraud
Copy link
Collaborator Author

nbraud commented Jun 22, 2019

This is blocked on pypa/setuptools#1515, since we to either invoke the test and release commands, or change the development workflow (invoking pytest and twine directly).

@duckinator
Copy link
Owner

duckinator commented Jun 24, 2019

This is also blocked on pypa/pip#6041, for an equivalent to ./setup.py build.

@duckinator duckinator closed this Jun 24, 2019
@duckinator duckinator reopened this Jun 24, 2019
@duckinator
Copy link
Owner

Whoops, didn't mean to close it. >.>

@duckinator duckinator added blocked Needs something else to happen first enhancement New feature or request labels Jun 24, 2019
@duckinator
Copy link
Owner

It looks like the pep517 package provides this:

python3 -m pep517.check path/to/source  # source dir containing pyproject.toml

and

python -m pep517.build path/to/source  # source dir containing pyproject.toml

I think I'll experiment with making a little tool built on top of pep517+twine+the zipapp module which provides a coherent interface for wheel/sdist/zipapp builds and releasing wheel/sdist to pypi.

@nbraud
Copy link
Collaborator Author

nbraud commented Jun 24, 2019

@duckinator TBH, in the current state of things, the “small tool” could literally be a shell script calling pep517 and twine (though making it in Python will likely be nicer).

@duckinator
Copy link
Owner

@nbraud when you have a moment, could you rebase this? ❤️ (no rush, since we can't merge it yet, just would like a more accurate diff to see what the state of it is~)

pypa/setuptools#1675 made it optional, and was merged in v40.9.0.
@nbraud
Copy link
Collaborator Author

nbraud commented Jun 26, 2019

@duckinator Done; for what it's worth, you could also have done it, since PRs have “Allow edits from maintainers” checked by default, and there couldn't have been any conflict.

@duckinator
Copy link
Owner

Okay, nice, this PR is down to just locking down the setuptools version and removing setup.py like I thought it would be. :3

@duckinator duckinator removed the blocked Needs something else to happen first label Jun 16, 2020
@duckinator duckinator mentioned this pull request Jun 16, 2020
bors bot added a commit that referenced this pull request Jun 16, 2020
136: Remove setup.py. r=duckinator a=duckinator

Replaces and closes #58.

Original description for #58:

> Followup on #55.
> 
> - [x] Get rid of `setup.py`, which was made optional by pypa/setuptools#1675.
> - [x] Set a version requirement for `setuptools`.

Co-authored-by: Nicolas Braud-Santoni <[email protected]>
Co-authored-by: Ellen Marie Dash <[email protected]>
@bors bors bot closed this in cc25ac1 Jun 16, 2020
@bors bors bot closed this in #136 Jun 16, 2020
@nbraud nbraud deleted the no-setup.py branch February 5, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants