Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broaden qwenlm CDN allowlist rule #2716

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Broaden qwenlm CDN allowlist rule #2716

merged 1 commit into from
Feb 4, 2025

Conversation

sammacbeth
Copy link
Collaborator

Asana Task/Github Issue: https://app.asana.com/0/1206670747178362/1209315576561957

Description

Our original allowlist rule hard-coded a specific version of the frontend loaded from the CDN. Since then the site has already updated to a later version. This PR removes the version from the allowlist rule so this won't be an issue in future.

@sammacbeth sammacbeth requested review from a team as code owners February 4, 2025 09:58
Copy link

github-actions bot commented Feb 4, 2025

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Feb 4, 2025

Generated file outputs:

Time updated: Tue, 04 Feb 2025 09:58:43 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (13 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -7136,9 +7136,9 @@
                     },
                     "alicdn.com": {
                         "rules": [
                             {
-                                "rule": "alicdn.com/g/qwenweb/qwen-webui-fe/0.0.15",
+                                "rule": "alicdn.com/g/qwenweb/qwen-webui-fe/",
                                 "domains": [
                                     "qwenlm.ai"
                                 ],
                                 "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2700"
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -6574,9 +6574,9 @@
                     },
                     "alicdn.com": {
                         "rules": [
                             {
-                                "rule": "alicdn.com/g/qwenweb/qwen-webui-fe/0.0.15",
+                                "rule": "alicdn.com/g/qwenweb/qwen-webui-fe/",
                                 "domains": [
                                     "qwenlm.ai"
                                 ]
                             },

@sammacbeth sammacbeth requested a review from tagawa February 4, 2025 09:59
@sammacbeth sammacbeth added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 0aeb191 Feb 4, 2025
12 checks passed
@sammacbeth sammacbeth deleted the sammacbeth-patch-1 branch February 4, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants