Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Malicious Site Protection onByDefault subfeature override for macOS #2676

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

mallexxx
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/1202406491309510/1209190998168432/f
BSK PR: duckduckgo/BrowserServicesKit#1180
macOS PR: duckduckgo/macos-browser#3761
iOS PR: duckduckgo/iOS#3853

Description

  • Add Malicious Site Protection onByDefault subfeature override for macOS to enable rollout

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@mallexxx mallexxx requested review from a team as code owners January 23, 2025 07:40
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Jan 23, 2025

Generated file outputs:

Time updated: Thu, 23 Jan 2025 07:49:48 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -6788,8 +6788,13 @@
                     "domain": "broken.third-party.site",
                     "reason": "A test page that helps us verify if exceptions work correctly."
                 }
             ],
+            "features": {
+                "onByDefault": {
+                    "state": "enabled"
+                }
+            },
             "settings": {
                 "hashPrefixUpdateFrequency": 20,
                 "filterSetUpdateFrequency": 720
             }
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -6203,8 +6203,13 @@
                 {
                     "domain": "broken.third-party.site"
                 }
             ],
+            "features": {
+                "onByDefault": {
+                    "state": "enabled"
+                }
+            },
             "settings": {
                 "hashPrefixUpdateFrequency": 20,
                 "filterSetUpdateFrequency": 720
             }

@mallexxx mallexxx added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit a4f61ef Jan 23, 2025
6 checks passed
@mallexxx mallexxx deleted the alex/malsite-onbydefault-subfeature-override branch January 23, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants