-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove navigator credentials as no longer used #2674
Conversation
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Wed, 22 Jan 2025 22:12:03 GMT legacytrackers-unprotected-temporary.txt (14 more)
latestv4/android-config.json (13 more)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also remove references to navigatorCredentials
from:
- https://github.com/duckduckgo/privacy-configuration/blob/main/schema/features/webcompat.ts#L10
- https://github.com/duckduckgo/privacy-configuration/blob/main/overrides/macos-override.json#L214
- https://github.com/duckduckgo/privacy-configuration/blob/main/overrides/ios-override.json#L475
No they're where this feature moved to, sorry should have been clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, in that case all good from my angle 👍
Asana Task/Github Issue: https://app.asana.com/0/1200194497630846/1201614831475343/f
Description
We moved this feature under webCompat and so hasn't been part of the C-S-S bundle in a long time.
Feature change process:
Additional info:
Site breakage mitigation process:
Brief explanation
Reported URL:
Problems experienced:
Platforms affected:
Tracker(s) being unblocked:
Feature being disabled:
I have referenced the URL of this PR as the "reason" value for the exception (where applicable).
This change is a speculative mitigation to fix reported breakage.
Reference