Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Config: Changing featuresRequestHeader field name to match app code #2668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

malmstein
Copy link
Contributor

Asana Task/Github Issue: https://app.asana.com/0/1174433894299346/1208888211876105

Description

Preparations for sending app version as header
Renaming field to match app code

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@malmstein malmstein requested review from a team as code owners January 21, 2025 20:19
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Tue, 21 Jan 2025 20:19:35 GMT

legacy
trackers-unprotected-temporary.txt (13 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -188,9 +188,9 @@
                     "settings": {
                         "versions": [
                             {
                                 "appVersion": 52210000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": true,
                                     "cpm": true,
@@ -199,9 +199,9 @@
                                 }
                             },
                             {
                                 "appVersion": 52220000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 28,
                                 "featuresLogged": {
                                     "gpc": false,
                                     "cpm": false,
@@ -210,9 +210,9 @@
                                 }
                             },
                             {
                                 "appVersion": 52230000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": false,
                                     "cpm": true,
@@ -221,9 +221,9 @@
                                 }
                             },
                             {
                                 "appVersion": 52231000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": false,
                                     "cpm": true,
@@ -232,9 +232,9 @@
                                 }
                             },
                             {
                                 "appVersion": 52240000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": false,
                                     "cpm": true,
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -179,9 +179,9 @@
                     "settings": {
                         "versions": [
                             {
                                 "appVersion": 52210000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": true,
                                     "cpm": true,
@@ -190,9 +190,9 @@
                                 }
                             },
                             {
                                 "appVersion": 52220000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 28,
                                 "featuresLogged": {
                                     "gpc": false,
                                     "cpm": false,
@@ -201,9 +201,9 @@
                                 }
                             },
                             {
                                 "appVersion": 52230000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": false,
                                     "cpm": true,
@@ -212,9 +212,9 @@
                                 }
                             },
                             {
                                 "appVersion": 52231000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": false,
                                     "cpm": true,
@@ -223,9 +223,9 @@
                                 }
                             },
                             {
                                 "appVersion": 52240000,
-                                "daysAfterBuild": 6,
+                                "daysUntilLoggingStarts": 6,
                                 "daysLogging": 10,
                                 "featuresLogged": {
                                     "gpc": false,
                                     "cpm": true,
v4/extension-brave-config.json (12 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

@malmstein malmstein changed the title changing value to match app code Privacy Config: Changing value to match app code Jan 21, 2025
@malmstein malmstein changed the title Privacy Config: Changing value to match app code Privacy Config: Changing featuresRequestHeader field name to match app code Jan 21, 2025
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@malmstein malmstein enabled auto-merge January 22, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants