-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy Config: Changing featuresRequestHeader field name to match app code #2668
base: main
Are you sure you want to change the base?
Conversation
Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana). |
Generated file outputs:Time updated: Tue, 21 Jan 2025 20:19:35 GMT legacytrackers-unprotected-temporary.txt (13 more)
v3/android-config.json--- v3/android-config.json
+++ v3/android-config.json
@@ -188,9 +188,9 @@
"settings": {
"versions": [
{
"appVersion": 52210000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 10,
"featuresLogged": {
"gpc": true,
"cpm": true,
@@ -199,9 +199,9 @@
}
},
{
"appVersion": 52220000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 28,
"featuresLogged": {
"gpc": false,
"cpm": false,
@@ -210,9 +210,9 @@
}
},
{
"appVersion": 52230000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 10,
"featuresLogged": {
"gpc": false,
"cpm": true,
@@ -221,9 +221,9 @@
}
},
{
"appVersion": 52231000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 10,
"featuresLogged": {
"gpc": false,
"cpm": true,
@@ -232,9 +232,9 @@
}
},
{
"appVersion": 52240000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 10,
"featuresLogged": {
"gpc": false,
"cpm": true,
latestv4/android-config.json--- v4/android-config.json
+++ v4/android-config.json
@@ -179,9 +179,9 @@
"settings": {
"versions": [
{
"appVersion": 52210000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 10,
"featuresLogged": {
"gpc": true,
"cpm": true,
@@ -190,9 +190,9 @@
}
},
{
"appVersion": 52220000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 28,
"featuresLogged": {
"gpc": false,
"cpm": false,
@@ -201,9 +201,9 @@
}
},
{
"appVersion": 52230000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 10,
"featuresLogged": {
"gpc": false,
"cpm": true,
@@ -212,9 +212,9 @@
}
},
{
"appVersion": 52231000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 10,
"featuresLogged": {
"gpc": false,
"cpm": true,
@@ -223,9 +223,9 @@
}
},
{
"appVersion": 52240000,
- "daysAfterBuild": 6,
+ "daysUntilLoggingStarts": 6,
"daysLogging": 10,
"featuresLogged": {
"gpc": false,
"cpm": true,
v4/extension-brave-config.json (12 more)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Asana Task/Github Issue: https://app.asana.com/0/1174433894299346/1208888211876105
Description
Preparations for sending app version as header
Renaming field to match app code
Feature change process:
Additional info:
Site breakage mitigation process:
Brief explanation
Reported URL:
Problems experienced:
Platforms affected:
Tracker(s) being unblocked:
Feature being disabled:
I have referenced the URL of this PR as the "reason" value for the exception (where applicable).
This change is a speculative mitigation to fix reported breakage.
Reference