Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Add UserScriptActionsManager package and a placeholder for HistoryView user script #3845

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jan 22, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209210475594362/f

Description:
This change bumps BSK to a version with macOS-related updates for History View.

Steps to test this PR:
Verify that CI is green.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Jan 22, 2025
@ayoy ayoy changed the title Add UserScriptActionsManager package and a placeholder for HistoryView user script [macOS] Add UserScriptActionsManager package and a placeholder for HistoryView user script Jan 22, 2025
@ayoy ayoy marked this pull request as ready for review January 22, 2025 07:25
@ayoy ayoy requested a review from SabrinaTardio January 22, 2025 08:19
@ayoy ayoy assigned SabrinaTardio and unassigned ayoy Jan 22, 2025
@ayoy ayoy merged commit 41ea69d into main Jan 23, 2025
13 checks passed
@ayoy ayoy deleted the dominik/html-history branch January 23, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants