Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor broken site report message handlers #2939

Merged
merged 11 commits into from
Feb 17, 2025
Merged

Refactor broken site report message handlers #2939

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
53504de
Fix breakage report race condition.
sammacbeth Feb 5, 2025
fbd3cb3
Create a dashboard messaging component to handle dashboard data and b…
sammacbeth Feb 6, 2025
7f4d812
Update tests to use a submitBrokenSiteReport stub
sammacbeth Feb 6, 2025
9e4c3d0
Update shared/js/background/components/dashboard-messaging.js
sammacbeth Feb 13, 2025
04964d6
Unit tests for broken site report sending.
sammacbeth Feb 14, 2025
d8cb036
Re-create ToggleReports for each test to prevent context leakage
sammacbeth Feb 14, 2025
22ecc30
Workaround lastSentDay still using global settings
sammacbeth Feb 14, 2025
511ba7c
Document where all the dashboard message handlers are.
sammacbeth Feb 14, 2025
4d2a979
lint fix
sammacbeth Feb 14, 2025
8481641
Correct mock config version
sammacbeth Feb 14, 2025
a7ef3f7
Update shared/js/background/components/dashboard-messaging.js
sammacbeth Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions shared/js/background/broken-site-report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,8 @@ export async function breakageReportForTab({
export async function sendBreakageReportForCurrentTab({ pixelName, currentTab, category, description, reportFlow }) {
await settings.ready();
await tdsStorage.ready('config');
kzar marked this conversation as resolved.
Show resolved Hide resolved
// wait for onload callbacks (to ensure that config has been correctly processed)
await tdsStorage.config.allLoadingFinished

const tab = currentTab || (await tabManager.getOrRestoreCurrentTab());
if (!tab) {
Expand Down
Loading