Skip to content
This repository has been archived by the owner on Jan 10, 2019. It is now read-only.

Remove redundancy in code of the add button of bangs #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lunaticmonk
Copy link

Reviewer:

Description:

Fixes #201

Steps to test this PR

The add button of the bangs.

Automated tests:

  • Unit tests
  • Integration tests
Reviewer Checklist:
  • Ensure the PR solves the problem
  • Review every line of code
  • Ensure the PR does no harm by testing the changes thoroughly
  • Get help if you're uncomfortable with any of the above!
  • Determine if there are any quick wins that improve the implementation
PR Author Checklist:
  • Get advice or leverage existing code
  • Agree on technical approach with reviewer (if the changes are nuanced)
  • Ensure that there is a testing strategy (and documented non-automated tests)
  • Ensure there is a documented monitoring strategy (if necessary)
  • Consider systems implications

@lunaticmonk
Copy link
Author

@jdorweiler Please review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant